Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added ldap tls connection support #5

Merged
merged 1 commit into from
Nov 1, 2019
Merged

added ldap tls connection support #5

merged 1 commit into from
Nov 1, 2019

Conversation

kfreiman
Copy link
Contributor

@kfreiman kfreiman commented Oct 31, 2019 •
edited
Loading

Proposed Changes

  • Support TLS connection to LDAP via additional env var WERTHER_LDAP_IS_TLS=1

@codecov-io
Copy link

Codecov Report

Merging #5 into master will decrease coverage by 0.69%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #5     +/-   ##
=========================================
- Coverage   74.57%   73.88%   -0.7%     
=========================================
  Files           8        8             
  Lines         531      536      +5     
=========================================
  Hits          396      396             
- Misses        104      109      +5     
  Partials       31       31
Impacted Files Coverage Δ
internal/ldapclient/ldapclient.go 72.15% <14.28%> (-2.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9a1c62...9f2be78. Read the comment docs.

@konstlepa
Copy link
Member

Hello, kfreiman 😀 Thank you very much for your contribution!

@konstlepa konstlepa merged commit d8c1f47 into i-core:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kfreiman @codecov-io @konstlepa